lkml.org 
[lkml]   [2023]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] sched/psi: iterate through cgroups directly
    On Thu, Feb 09, 2023 at 12:16:54AM +0800, Kairui Song <ryncsn@gmail.com> wrote:
    > Signed-off-by: Kairui Song <kasong@tencent.com>
    > Signed-off-by: Kairui Song <ryncsn@gmail.com>

    Typo?

    > -static inline struct psi_group *task_psi_group(struct task_struct *task)
    > +static inline struct psi_group *psi_iter_first(struct task_struct *task, void **iter)
    > {
    > #ifdef CONFIG_CGROUPS
    > - if (static_branch_likely(&psi_cgroups_enabled))
    > - return cgroup_psi(task_dfl_cgroup(task));
    > + if (static_branch_likely(&psi_cgroups_enabled)) {
    > + struct cgroup *cgroup = task_dfl_cgroup(task);
    > +
    > + *iter = cgroup_parent(cgroup);

    This seems to skip a cgroup level -- maybe that's the observed
    performance gain?

    > + return cgroup_psi(cgroup);
    > + }
    > #endif
    > return &psi_system;
    > }

    Michal
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-03-27 00:15    [W:4.238 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site