lkml.org 
[lkml]   [2023]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] mtd: spi-nor: fix memory leak when using debugfs_lookup()
Am 2023-02-08 17:02, schrieb Greg Kroah-Hartman:
> When calling debugfs_lookup() the result must have dput() called on it,
> otherwise the memory will leak over time. To solve this, remove the
> lookup and create the directory on the first device found, and then
> remove it when the module is unloaded.
>
> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: Pratyush Yadav <pratyush@kernel.org>
> Cc: Michael Walle <michael@walle.cc>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Reviewed-by: Michael Walle <michael@walle.cc>

one nit below I didn't notice earlier, no need to send a new
patch version just for that.

..

> +void spi_nor_debugfs_shutdown(void)
> +{
> + if (rootdir)
> + debugfs_remove(rootdir);

debugfs_remove() already has a check for NULL.

\
 
 \ /
  Last update: 2023-03-27 00:15    [W:0.151 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site