Messages in this thread | | | Date | Wed, 8 Feb 2023 17:05:05 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH 1/2] thermal: tegra-bpmp: Handle offline zones |
| |
On Wed, Feb 08, 2023 at 05:35:48PM +0200, Mikko Perttunen wrote: > On 2/8/23 12:31, Thierry Reding wrote: > > On Tue, Feb 07, 2023 at 03:56:08PM +0200, Mikko Perttunen wrote: > > > From: Mikko Perttunen <mperttunen@nvidia.com> > > > > > > Thermal zones located in power domains may not be accessible when > > > the domain is powergated. In this situation, reading the temperature > > > will return -BPMP_EFAULT and the temperature is considered to be > > > -256C for calculating trips. > > > > Where's that -256C being set? I only see THERMAL_TEMP_INVALID being set > > as the default for a zone, but that's not -274C, not -256C. If that's > > the temperature that you're referring to, it might be better to state > > that we rely on the default temperature rather than any specific number. > > > > Thierry > > It is based on BPMP's internal behavior.
Okay, maybe clarify that part of the sentence then. Could be something like:
... will return -BPMP_EFAULT. When evaluating trips, BPMP will internally use -256C as the temperature for offline zones.
Thierry [unhandled content-type:application/pgp-signature] | |