Messages in this thread | | | From | Feiyang Chen <> | Date | Wed, 8 Feb 2023 14:39:57 +0800 | Subject | Re: [PATCH 3/3] selftests/nolibc: Add support for LoongArch |
| |
On Wed, 8 Feb 2023 at 12:34, Paul E. McKenney <paulmck@kernel.org> wrote: > > On Wed, Feb 08, 2023 at 04:54:07AM +0100, Willy Tarreau wrote: > > On Tue, Feb 07, 2023 at 10:09:42AM +0800, chris.chenfeiyang@gmail.com wrote: > > > From: Feiyang Chen <chenfeiyang@loongson.cn> > > > > > > Add support for LoongArch (64 bit) to nolibc selftest. > > > > Please also mention in this one that the makefile was reindented with > > no other change than adding entries for loongarch, this will save > > those reading this patch later from checking that the rest was not > > changed. > > I like Willy's suggestion, but even better would be to put the whitespace > changes into one commit, and the code changes into another commit. > This makes it a lot easier for reviewers and future nolibc developers > to quickly and easily see exactly what changed. >
Hi, Willy, Paul,
I get it now, thank you.
> And one of those future nolibc maintainers just might be you! ;-) > > Thanx, Paul
Thanks, Feiyang
| |