Messages in this thread | | | From | "Winkler, Tomas" <> | Subject | RE: [char-misc-next v2 1/2] drm/i915/mtl: Define GSC Proxy component interface | Date | Wed, 8 Feb 2023 12:35:11 +0000 |
| |
> On Sun, Feb 05, 2023 at 08:11:31PM +0200, Tomas Winkler wrote: > > From: Alexander Usyskin <alexander.usyskin@intel.com> > > > > GSC Proxy component is used for communication between the Intel > > graphics driver and MEI driver. > > > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > > --- > > V2: This patch was missing in the first series. > > > > MAINTAINERS | 1 + > > include/drm/i915_component.h | 3 +- > > include/drm/i915_gsc_proxy_mei_interface.h | 36 > > ++++++++++++++++++++++ > > 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 > > include/drm/i915_gsc_proxy_mei_interface.h > > > Why do you add .h files in include/drm/ yet only use them in drivers/mei/ ? > > Shouldn't they just live in the mei subdir? Especially given that you also want > to maintain them through the mei subsystem as per this change:
Rigth, will drop, this part.
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS index > > c81bbb771678..2c432b4d8506 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -10570,6 +10570,7 @@ S: Supported > > F: Documentation/driver-api/mei/* > > F: drivers/misc/mei/ > > F: drivers/watchdog/mei_wdt.c > > +F: include/drm/i915_gsc_proxy_mei_interface.h > > F: include/linux/mei_aux.h > > F: include/linux/mei_cl_bus.h > > F: include/uapi/linux/mei.h > > And I would need some i915 maintainer acks before I could take this in my > tree.
Okay
> > thanks, > > greg k-h
| |