Messages in this thread | | | Date | Wed, 8 Feb 2023 13:31:18 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 02/10] staging: rtl8192e: Calculate definition of MSR_LINK_MASK |
| |
On Tue, Feb 07, 2023 at 07:16:22PM +0100, Philipp Hortmann wrote: > Calculate definition of MSR_LINK_MASK ((1<<0)|(1<<1)) = 3. Equation is not > accepted by checkpatch because of missing spaces. > > Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h > index 1546bb575293..20a35c9caee8 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h > @@ -170,7 +170,7 @@ enum _RTL8192PCI_HW { > #define BW_OPMODE_20MHZ BIT2 > IC_VERRSION = 0x301, > MSR = 0x303, > -#define MSR_LINK_MASK ((1<<0)|(1<<1)) > +#define MSR_LINK_MASK 3
This is a bit field, it should be: #define MSR_LINK_MASK (BIT(1) | BIT(0)) right?
thanks,
greg k-h
| |