lkml.org 
[lkml]   [2023]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [External] [PATCH] erofs: relinquish volume with mutex held
From
在 2023/2/8 15:32, Jingbo Xu 写道:
> Relinquish fscache volume with mutex held. Otherwise if a new domain is
> registered when the old domain with the same name gets removed from the
> list but not relinquished yet, fscache may complain the collision.
>
> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>

Reviewed-by: Jia Zhu <zhujia.zj@bytedance.com>

> ---
> fs/erofs/fscache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
> index 8da6e05e9d23..35b2d8b5773e 100644
> --- a/fs/erofs/fscache.c
> +++ b/fs/erofs/fscache.c
> @@ -328,8 +328,8 @@ static void erofs_fscache_domain_put(struct erofs_domain *domain)
> kern_unmount(erofs_pseudo_mnt);
> erofs_pseudo_mnt = NULL;
> }
> - mutex_unlock(&erofs_domain_list_lock);
> fscache_relinquish_volume(domain->volume, NULL, false);
> + mutex_unlock(&erofs_domain_list_lock);
> kfree(domain->domain_id);
> kfree(domain);
> return;

\
 
 \ /
  Last update: 2023-03-27 00:14    [W:1.910 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site