Messages in this thread | | | Date | Wed, 8 Feb 2023 09:38:20 +0100 | Subject | Re: [PATCH v4 1/7] dt-bindings: phy: Add qcom,snps-eusb2-repeater schema file | From | Krzysztof Kozlowski <> |
| |
On 07/02/2023 14:55, Abel Vesa wrote: > The SM8550 SoC uses Synopsis eUSB2 repeater found in PM8550b. > Add a dt-binding schema for the new driver. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > > The v3 (rfc) is here: > https://lore.kernel.org/all/20230202133816.4026990-3-abel.vesa@linaro.org/ > > Changes since v3: > * made this patch the first one in the series to fix the binding check > for the 2nd patch. > * dropped the compatible for pmic in the example. This is due to the > dependency between this patch and the next one. > > .../phy/qcom,snps-eusb2-repeater.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml > > diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml > new file mode 100644 > index 000000000000..54afab7e21fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/qcom,snps-eusb2-repeater.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Synopsis eUSB2 to USB 2.0 repeater > + > +maintainers: > + - Abel Vesa <abel.vesa@linaro.org> > +
It would be really nice to have here "description:" with few words what this repeater is and what it does.
Anyway:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |