Messages in this thread | | | Date | Wed, 08 Feb 2023 09:06:24 +0100 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH 1/3] nolibc: Add statx() support to implement sys_stat() |
| |
On Wed, Feb 8, 2023, at 08:42, Feiyang Chen wrote: > On Wed, 8 Feb 2023 at 11:31, Willy Tarreau <w@1wt.eu> wrote: >> >> I generally agree with the Arnd's points overall and I'm fine with the >> rest of your series. On this specific point, I'm fine with your proposal, >> let's just start with sys_statx() only on this arch, please add a comment >> about this possibility in the commit message that brings statx(), >> indicating that other archs are likely to benefit from it as well, and >> let's see after this if we can migrate all archs to statx. >> > > We have a problem if we just start with sys_statx() only on this arch. > When struct stat is not defined, what should we do with stat() in the > nolibc selftest?
To clarify: your proposed implementation of the stat() function that fills the nolibc 'struct stat' based on information from 'struct statx' is fine here. Just remove the 'struct sys_stat_struct' definition loongarch but keep 'struct stat'.
Arnd
| |