Messages in this thread | | | Date | Thu, 9 Feb 2023 10:29:00 +0800 | Subject | Re: [PATCH v2 1/2] erofs: update print symbols for various flags in trace | From | Gao Xiang <> |
| |
On 2023/2/8 19:29, Jingbo Xu wrote: > As new flags introduced, the corresponding print symbols for trace are > not added accordingly. Add these missing print symbols for these flags. > > Also remove the print symbol for EROFS_GET_BLOCKS_RAW as it is going to > be removed soon. > > Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com> > --- > v2: remove print symbol for EROFS_GET_BLOCKS_RAW > --- > include/trace/events/erofs.h | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/include/trace/events/erofs.h b/include/trace/events/erofs.h > index e095d36db939..cf4a0d28b178 100644 > --- a/include/trace/events/erofs.h > +++ b/include/trace/events/erofs.h > @@ -19,12 +19,17 @@ struct erofs_map_blocks; > { 1, "DIR" }) > > #define show_map_flags(flags) __print_flags(flags, "|", \ > - { EROFS_GET_BLOCKS_RAW, "RAW" })
Should we remove this in the next patch? Otherwise it looks good to me.
Thanks, Gao XIang
> + { EROFS_GET_BLOCKS_FIEMAP, "FIEMAP" }, \ > + { EROFS_GET_BLOCKS_READMORE, "READMORE" }, \ > + { EROFS_GET_BLOCKS_FINDTAIL, "FINDTAIL" }) > > #define show_mflags(flags) __print_flags(flags, "", \ > - { EROFS_MAP_MAPPED, "M" }, \ > - { EROFS_MAP_META, "I" }, \ > - { EROFS_MAP_ENCODED, "E" }) > + { EROFS_MAP_MAPPED, "M" }, \ > + { EROFS_MAP_META, "I" }, \ > + { EROFS_MAP_ENCODED, "E" }, \ > + { EROFS_MAP_FULL_MAPPED, "F" }, \ > + { EROFS_MAP_FRAGMENT, "R" }, \ > + { EROFS_MAP_PARTIAL_REF, "P" }) > > TRACE_EVENT(erofs_lookup, >
| |