Messages in this thread | | | From | Feiyang Chen <> | Date | Thu, 9 Feb 2023 10:02:56 +0800 | Subject | Re: [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on statx() when available |
| |
On Wed, 8 Feb 2023 at 18:39, Willy Tarreau <w@1wt.eu> wrote: > > Hi Feiyang, > > On Wed, Feb 08, 2023 at 06:17:51PM +0800, chris.chenfeiyang@gmail.com wrote: > > From: Feiyang Chen <chenfeiyang@loongson.cn> > > > > loongarch and riscv32 only have statx(). arc, hexagon, nios2 and > > openrisc have statx() and stat64() but not stat() or newstat(). > > Add statx() and make stat() rely on statx() to make them happy. > > Thanks for this, that's way better. I'm just having one small request > below: > > > +/* > > + * int statx(int fd, const char *path, int flags, unsigned int mask, struct statx *buf); > > + */ > > + > > +static __attribute__((unused)) > > +int sys_statx(int fd, const char *path, int flags, unsigned int mask, struct statx *buf) > > +{ > > + return my_syscall5(__NR_statx, fd, path, flags, mask, buf); > > +} > > + > > +static __attribute__((unused)) > > +int statx(int fd, const char *path, int flags, unsigned int mask, struct statx *buf) > > +{ > > + int ret = sys_statx(fd, path, flags, mask, buf); > > + > > + if (ret < 0) { > > + SET_ERRNO(-ret); > > + ret = -1; > > + } > > + return ret; > > +} > > Please guard these inside #if defined(__NR_statx) so that this can still > be used as-is from slightly older toolchains that provide their own kernel > includes. >
Hi, Willy,
OK.
Thanks, Feiyang
> The rest of the series looks pretty good to me. > > Thank you! > Willy
| |