lkml.org 
[lkml]   [2023]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver
On Mon, Jan 30, 2023 at 06:25:25PM +0530, devi priya wrote:
> +static const struct msm_pingroup ipq9574_groups[] = {
> + PINGROUP(0, sdc_data, qspi_data, qdss_traceclk_b, _, _, _, _, _, _),
> + PINGROUP(1, sdc_data, qspi_data, qdss_tracectl_b, _, _, _, _, _, _),
> + PINGROUP(2, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _),
> + PINGROUP(3, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _),
> + PINGROUP(4, sdc_cmd, qspi_cs, qdss_tracedata_b, _, _, _, _, _, _),
> + PINGROUP(5, sdc_clk, qspi_clk, qdss_tracedata_b, _, _, _, _, _,
> + _),

Please avoid line wrapping these, it just makes it hard to read.

[..]
> +};
> +
> +/* Reserving GPIO59 for controlling the QFPROM LDO regulator */

This seems like a property of the board, please use gpio-reserved-ranges
in the DT node instead.

Thanks,
Bjorn

\
 
 \ /
  Last update: 2023-03-27 00:15    [W:1.307 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site