Messages in this thread | | | Date | Tue, 7 Feb 2023 17:17:46 +0100 | Subject | Re: [PATCH V2 4/8] kvm: x86/mmu: Set mmu->sync_page as NULL for direct paging | From | Paolo Bonzini <> |
| |
On 2/7/23 16:57, Lai Jiangshan wrote: > From: Lai Jiangshan<jiangshan.ljs@antgroup.com> > > mmu->sync_page for direct paging is never called. > > And both mmu->sync_page and mm->invlpg only make sense in shadowpaging. > Setting mmu->sync_page as NULL for direct paging makes it consistent > with mm->invlpg which is set NULL for the case. > > Signed-off-by: Lai Jiangshan<jiangshan.ljs@antgroup.com>
I'd rather have a WARN_ON_ONCE in kvm_sync_page(), otherwise looks good.
Paolo
| |