Messages in this thread | | | From | Vinod Polimera <> | Subject | RE: [PATCH v12 09/14] drm/msm/dp: disable self_refresh_aware after entering psr | Date | Tue, 7 Feb 2023 14:28:13 +0000 |
| |
> -----Original Message----- > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Sent: Tuesday, January 31, 2023 6:19 PM > To: Vinod Polimera (QUIC) <quic_vpolimer@quicinc.com>; dri- > devel@lists.freedesktop.org; linux-arm-msm@vger.kernel.org; > freedreno@lists.freedesktop.org; devicetree@vger.kernel.org > Cc: Sankeerth Billakanti (QUIC) <quic_sbillaka@quicinc.com>; linux- > kernel@vger.kernel.org; robdclark@gmail.com; dianders@chromium.org; > swboyd@chromium.org; Kalyan Thota (QUIC) <quic_kalyant@quicinc.com>; > Kuogee Hsieh (QUIC) <quic_khsieh@quicinc.com>; Vishnuvardhan > Prodduturi (QUIC) <quic_vproddut@quicinc.com>; Bjorn Andersson (QUIC) > <quic_bjorande@quicinc.com>; Abhinav Kumar (QUIC) > <quic_abhinavk@quicinc.com> > Subject: Re: [PATCH v12 09/14] drm/msm/dp: disable self_refresh_aware > after entering psr > > On 30/01/2023 17:11, Vinod Polimera wrote: > > From: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > > > > Updated frames get queued if self_refresh_aware is set when the > > sink is in psr. To support bridge enable and avoid queuing of update > > frames, reset the self_refresh_aware state after entering psr. > > > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > > Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com> > > --- > > drivers/gpu/drm/msm/dp/dp_drm.c | 25 ++++++++++++++++++++++++- > > 1 file changed, 24 insertions(+), 1 deletion(-) > > As I stated in v11's discussion, I do not like the way this change plays > with the self_refresh_aware. Please find another way to work around the > timing issue (let's probably continue the discussion back in v11). > Currently we are not able to reproduce the issue with KASAN enabled and minimum cpu frequency builds. We can revisit this patch if it is reproduced in future. Meanwhile I think on handling it in a different way. Can we not consider this patch for current merge?
> -- > With best wishes > Dmitry
Thanks, Vinod P.
| |