lkml.org 
[lkml]   [2023]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] Revert "venus: firmware: Correct non-pix start and end addresses"
    Date
    This reverts commit a837e5161cfffbb3242cc0eb574f8bf65fd32640, which broke
    probing of the venus driver, at least on the SC7180 SoC HP X2 Chromebook:

    [ 11.455782] qcom-venus aa00000.video-codec: Adding to iommu group 11
    [ 11.506980] qcom-venus aa00000.video-codec: non legacy binding
    [ 12.143432] qcom-venus aa00000.video-codec: failed to reset venus core
    [ 12.156440] qcom-venus: probe of aa00000.video-codec failed with error -110

    Matthias Kaehlcke also reported that the same change caused a regression in
    SC7180 and sc7280, that prevents AOSS from entering sleep mode during system
    suspend. So let's revert this commit for now to fix both issues.

    Fixes: a837e5161cff ("venus: firmware: Correct non-pix start and end addresses")
    Reported-by: Matthias Kaehlcke <mka@chromium.org>
    Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
    ---

    drivers/media/platform/qcom/venus/firmware.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
    index 142d4c74017c..d59ecf776715 100644
    --- a/drivers/media/platform/qcom/venus/firmware.c
    +++ b/drivers/media/platform/qcom/venus/firmware.c
    @@ -38,8 +38,8 @@ static void venus_reset_cpu(struct venus_core *core)
    writel(fw_size, wrapper_base + WRAPPER_FW_END_ADDR);
    writel(0, wrapper_base + WRAPPER_CPA_START_ADDR);
    writel(fw_size, wrapper_base + WRAPPER_CPA_END_ADDR);
    - writel(0, wrapper_base + WRAPPER_NONPIX_START_ADDR);
    - writel(0, wrapper_base + WRAPPER_NONPIX_END_ADDR);
    + writel(fw_size, wrapper_base + WRAPPER_NONPIX_START_ADDR);
    + writel(fw_size, wrapper_base + WRAPPER_NONPIX_END_ADDR);

    if (IS_V6(core)) {
    /* Bring XTSS out of reset */
    --
    2.39.1
    \
     
     \ /
      Last update: 2023-03-27 00:12    [W:7.223 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site