Messages in this thread | | | From | Michał Krawczyk <> | Date | Tue, 7 Feb 2023 10:17:39 +0100 | Subject | Re: [PATCH v2] media: venus: dec: Fix handling of the start cmd |
| |
pon., 30 sty 2023 o 14:55 Michał Krawczyk <mk@semihalf.com> napisał(a): > > From: Michał Krawczyk <mk@semihalf.com> > > The decoder driver should clear the last_buffer_dequeued flag of the > capture queue upon receiving V4L2_DEC_CMD_START. > > The last_buffer_dequeued flag is set upon receiving EOS (which always > happens upon receiving V4L2_DEC_CMD_STOP). > > Without this patch, after issuing the V4L2_DEC_CMD_STOP and > V4L2_DEC_CMD_START, the vb2_dqbuf() function will always fail, even if > the buffers are completed by the hardware. > > Fixes: beac82904a87 ("media: venus: make decoder compliant with stateful codec API") > > Signed-off-by: Michał Krawczyk <mk@semihalf.com>
Hello,
Did anyone have a chance to take a look at this patch? It's fairly simple, but lack of this fix can have a big impact on the V4L2 applications which implement the flush mechanism using the stop/start commands, especially in the middle of the video.
Thank you, Michał
| |