lkml.org 
[lkml]   [2023]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA
    From
    On 7.02.2023 21:56, Jakub Kicinski wrote:
    > On Sun, 5 Feb 2023 20:53:31 +0300 arinc9.unal@gmail.com wrote:
    >> From: Arınç ÜNAL <arinc.unal@arinc9.com>
    >>
    >> The special tag is only enabled when the first MAC uses DSA. However, it
    >> must be enabled when any MAC uses DSA. Change the check accordingly.
    >>
    >> This fixes hardware DSA untagging not working on the second MAC of the
    >> MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the
    >> check that disables hardware DSA untagging for the second MAC of the MT7621
    >> and MT7623 SoCs.
    >>
    >> Fixes: a1f47752fd62 ("net: ethernet: mtk_eth_soc: disable hardware DSA untagging for second MAC")
    >
    > As Paolo pointed out to me off-list this is pretty much a revert of
    > commit under Fixes. Is this an actual regression fix, or second MAC
    > as DSA port never worked but now you found a way to make it work?

    Second MAC as DSA master after hardware DSA untagging was enabled never
    worked. I first disabled it to make the communication work again, then,
    with this patch, I found a way to make it work which is what should've
    been done with the commit for adding hardware DSA untagging support.

    Arınç

    \
     
     \ /
      Last update: 2023-03-27 00:14    [W:4.391 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site