lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] HID: logitech-hidpp: Retry commands when device is busy
    Date
    Handle the busy error coming from the device or receiver. The
    documentation says a busy error can be returned when:
    "
    Device (or receiver) cannot answer immediately to this request
    for any reason i.e:
    - already processing a request from the same or another SW
    - pipe full
    "

    Signed-off-by: Bastien Nocera <hadess@hadess.net>
    ---
    drivers/hid/hid-logitech-hidpp.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
    index 6386d3f023ca..ef497a82fe4e 100644
    --- a/drivers/hid/hid-logitech-hidpp.c
    +++ b/drivers/hid/hid-logitech-hidpp.c
    @@ -295,6 +295,7 @@ static int hidpp_send_message_sync(struct hidpp_device *hidpp,
    */
    *response = *message;

    +retry:
    ret = __hidpp_send_report(hidpp->hid_dev, message);

    if (ret) {
    @@ -321,6 +322,10 @@ static int hidpp_send_message_sync(struct hidpp_device *hidpp,
    response->report_id == REPORT_ID_HIDPP_VERY_LONG) &&
    response->fap.feature_index == HIDPP20_ERROR) {
    ret = response->fap.params[1];
    + if (ret == HIDPP20_ERROR_BUSY) {
    + dbg_hid("%s:got busy hidpp 2.0 error %02X, retrying\n", __func__, ret);
    + goto retry;
    + }
    dbg_hid("%s:got hidpp 2.0 error %02X\n", __func__, ret);
    goto exit;
    }
    --
    2.39.1
    \
     
     \ /
      Last update: 2023-03-27 00:11    [W:2.866 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site