Messages in this thread | | | Date | Mon, 6 Feb 2023 13:19:04 +0000 | From | Mark Brown <> | Subject | Re: [Patch V2 2/4] tpm: tegra: Support SPI tpm wait state detect |
| |
On Mon, Feb 06, 2023 at 12:02:56PM +0100, Paul Menzel wrote: > Am 03.02.23 um 14:01 schrieb Krishna Yarlagadda:
> > + /* If the SPI device has an IRQ then use that */ > > + if (dev->irq > 0) > > + irq = dev->irq; > > + else > > + irq = -1;
> Use ternary operator?
> irq = dev->irq > 0 ? dev->irq : -1;
No, please write the code using normal conditional instructions. This isn't the IOCCC and the ternery operator is rarely a legibility aid. [unhandled content-type:application/pgp-signature] | |