lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 4/4] mm: Remove get_kernel_pages()
    On Sat, 4 Feb 2023 at 09:36, Ira Weiny <ira.weiny@intel.com> wrote:
    >
    > The only caller to get_kernel_pages() [shm_get_kernel_pages()] has been
    > updated to not need it.
    >
    > Remove get_kernel_pages().
    >
    > Cc: Mel Gorman <mgorman@suse.de>
    > Cc: Al Viro <viro@zeniv.linux.org.uk>
    > Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
    > Cc: Christoph Hellwig <hch@lst.de>
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > Acked-by: John Hubbard <jhubbard@nvidia.com>
    > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
    > ---
    > include/linux/mm.h | 2 --
    > mm/swap.c | 30 ------------------------------
    > 2 files changed, 32 deletions(-)
    >

    Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

    -Sumit

    > diff --git a/include/linux/mm.h b/include/linux/mm.h
    > index 8f857163ac89..2041e6d4fa27 100644
    > --- a/include/linux/mm.h
    > +++ b/include/linux/mm.h
    > @@ -2095,8 +2095,6 @@ int __account_locked_vm(struct mm_struct *mm, unsigned long pages, bool inc,
    > struct task_struct *task, bool bypass_rlim);
    >
    > struct kvec;
    > -int get_kernel_pages(const struct kvec *iov, int nr_pages, int write,
    > - struct page **pages);
    > struct page *get_dump_page(unsigned long addr);
    >
    > bool folio_mark_dirty(struct folio *folio);
    > diff --git a/mm/swap.c b/mm/swap.c
    > index 70e2063ef43a..4c03ecab698e 100644
    > --- a/mm/swap.c
    > +++ b/mm/swap.c
    > @@ -158,36 +158,6 @@ void put_pages_list(struct list_head *pages)
    > }
    > EXPORT_SYMBOL(put_pages_list);
    >
    > -/*
    > - * get_kernel_pages() - pin kernel pages in memory
    > - * @kiov: An array of struct kvec structures
    > - * @nr_segs: number of segments to pin
    > - * @write: pinning for read/write, currently ignored
    > - * @pages: array that receives pointers to the pages pinned.
    > - * Should be at least nr_segs long.
    > - *
    > - * Returns number of pages pinned. This may be fewer than the number requested.
    > - * If nr_segs is 0 or negative, returns 0. If no pages were pinned, returns 0.
    > - * Each page returned must be released with a put_page() call when it is
    > - * finished with.
    > - */
    > -int get_kernel_pages(const struct kvec *kiov, int nr_segs, int write,
    > - struct page **pages)
    > -{
    > - int seg;
    > -
    > - for (seg = 0; seg < nr_segs; seg++) {
    > - if (WARN_ON(kiov[seg].iov_len != PAGE_SIZE))
    > - return seg;
    > -
    > - pages[seg] = kmap_to_page(kiov[seg].iov_base);
    > - get_page(pages[seg]);
    > - }
    > -
    > - return seg;
    > -}
    > -EXPORT_SYMBOL_GPL(get_kernel_pages);
    > -
    > typedef void (*move_fn_t)(struct lruvec *lruvec, struct folio *folio);
    >
    > static void lru_add_fn(struct lruvec *lruvec, struct folio *folio)
    >
    > --
    > 2.39.1

    \
     
     \ /
      Last update: 2023-03-27 00:10    [W:4.102 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site