lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names
    From


    On 2023/1/18 23:47, Krzysztof Kozlowski wrote:
    > On 18/01/2023 07:16, Yanhong Wang wrote:
    >> Some boards(such as StarFive VisionFive v2) require more than one value
    >> which defined by resets property, so the original definition can not
    >> meet the requirements. In order to adapt to different requirements,
    >> adjust the maxitems number definition.
    >>
    >> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
    >> ---
    >> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 9 +++------
    >> 1 file changed, 3 insertions(+), 6 deletions(-)
    >>
    >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
    >> index e26c3e76ebb7..baf2c5b9e92d 100644
    >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
    >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
    >> @@ -133,12 +133,9 @@ properties:
    >> - ptp_ref
    >>
    >> resets:
    >> - maxItems: 1
    >
    > Also, this does not make sense on its own and messes constraints for all
    > other users. So another no for entire patch.
    >

    Thanks. Change the properties of 'resets' and reset-names like this:

    resets:
    minItems: 1
    maxItems: 2

    reset-names:
    minItems: 1
    maxItems: 2

    Is it right? Do you have any other better suggestions?

    > Best regards,
    > Krzysztof
    >

    \
     
     \ /
      Last update: 2023-03-27 00:12    [W:5.897 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site