Messages in this thread | | | Date | Tue, 7 Feb 2023 10:51:32 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] [RESEND v4] printf: fix errname.c list |
| |
On (23/02/06 20:40), Arnd Bergmann wrote: > On most architectures, gcc -Wextra warns about the list of error > numbers containing both EDEADLK and EDEADLOCK: > > lib/errname.c:15:67: warning: initialized field overwritten [-Woverride-init] > 15 | #define E(err) [err + BUILD_BUG_ON_ZERO(err <= 0 || err > 300)] = "-" #err > | ^~~ > lib/errname.c:172:2: note: in expansion of macro 'E' > 172 | E(EDEADLK), /* EDEADLOCK */ > | ^ > > On parisc, a similar error happens with -ECANCELLED, which is an > alias for ECANCELED. > > Make the EDEADLK printing conditional on the number being distinct > from EDEADLOCK, and remove the -ECANCELLED bit completely as it > can never be hit. > > To ensure these are correct, add static_assert lines that verify > all the remaining aliases are in fact identical to the canonical > name. >
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
| |