lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH v2 20/22] sound: usb: Prevent starting of audio stream if in use
From
Hi Pierre,

On 1/26/2023 8:12 AM, Pierre-Louis Bossart wrote:
>
>
> On 1/25/23 21:14, Wesley Cheng wrote:
>> With USB audio offloading, an audio session is started from the ASoC
>> platform sound card and PCM devices. Likewise, the USB SND path is still
>> readily available for use, in case the non-offload path is desired. In
>> order to prevent the two entities from attempting to use the USB bus,
>> introduce a flag that determines when either paths are in use.
>>
>> If a PCM device is already in use, the check will return an error to
>> userspace notifying that the stream is currently busy. This ensures that
>> only one path is using the USB substream.
>
> It's good to maintain mutual exclusion, but it's still very hard for an
> application to figure out which card can be used when.
>
> Returning -EBUSY is not super helpful. There should be something like a
> notification or connection status so that routing decisions can be made
> without trial-and-error.
>

The USB offload driver does have access to the USB substream that is
being utilized/offloaded. Maybe in addition to this check, we can also
set the PCM runtime state as well (for that particular substream)? That
way userspace can fetch information about if the stream is busy or not.

Thanks
Wesley Cheng

\
 
 \ /
  Last update: 2023-03-27 00:11    [W:0.211 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site