Messages in this thread | | | From | Miguel Ojeda <> | Date | Tue, 7 Feb 2023 00:47:13 +0100 | Subject | Re: [PATCH v2 5/5] rust: types: implement `ForeignOwnable` for `Arc<T>` |
| |
On Wed, Feb 1, 2023 at 11:35 AM Andreas Hindborg <nmi@metaspace.dk> wrote: > > The last part of the sentence does not read clearly to me. Would this > make sense instead: > > // SAFETY: By the safety requirement of this function, we know that `ptr` came from > // a previous call to `Arc::into_foreign`, which guarantees that `ptr` is valid and > // holds a reference count increment that is transferrable to us.
In a private chat with Wedson he agreed the "owned" was a typo and he is fine with this change. Thus I rebased to apply this and avoid a v3 given it is trivial and almost at the top of the stack. If you want the `Reviewed-by`, please let me know!
Cheers, Miguel
| |