Messages in this thread | | | Date | Mon, 6 Feb 2023 14:22:02 -0800 | From | Josh Poimboeuf <> | Subject | Re: [PATCH 12/22] powerpc/cpu: Mark start_secondary_resume() __noreturn |
| |
On Mon, Feb 06, 2023 at 10:10:22PM +1100, Michael Ellerman wrote: > Josh Poimboeuf <jpoimboe@kernel.org> writes: > > start_secondary_resume() doesn't return. Annotate it as such. By > > extension this also makes arch_cpu_idle_dead() noreturn. > > Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ? > > Seems like it would be good documentation, even if it's not required > once the generic prototype is __noreturn.
Yeah, agreed. Maybe I'll do that (for all the implementations) with patch 22.
> But not a show-stopper. > > Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Thanks!
-- Josh
| |