lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] media: dt-bindings: ov2685: convert to dtschema
    Date

    On Mon, 06 Feb 2023 21:23:16 +0100, Luca Weiss wrote:
    > Convert the text-based dt-bindings to yaml.
    >
    > Changes from original txt:
    > * Take wording for various properties from other yaml bindings, this
    > removes e.g. volt amount from schema since it isn't really relevant
    > and the datasheet is a better source.
    > * Don't make reset-gpios a required property since it can be tied to
    > DOVDD instead.
    >
    > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
    > ---
    > .../devicetree/bindings/media/i2c/ov2685.txt | 41 ---------
    > .../devicetree/bindings/media/i2c/ovti,ov2685.yaml | 101 +++++++++++++++++++++
    > MAINTAINERS | 1 +
    > 3 files changed, 102 insertions(+), 41 deletions(-)
    >

    My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
    on your patch (DT_CHECKER_FLAGS is new in v5.13):

    yamllint warnings/errors:

    dtschema/dtc warnings/errors:
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'clocks' is a required property
    From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'clock-names' is a required property
    From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'dvdd-supply' is a required property
    From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'avdd-supply' is a required property
    From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'dovdd-supply' is a required property
    From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml

    doc reference errors (make refcheckdocs):

    See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230206-ov2685-dtschema-v1-1-9e4da3474c10@z3ntu.xyz

    The base for the series is generally the latest rc1. A different dependency
    should be noted in *this* patch.

    If you already ran 'make dt_binding_check' and didn't see the above
    error(s), then make sure 'yamllint' is installed and dt-schema is up to
    date:

    pip3 install dtschema --upgrade

    Please check and re-submit after running the above command yourself. Note
    that DT_SCHEMA_FILES can be set to your schema file to speed up checking
    your schema. However, it must be unset to test all examples with your schema.

    \
     
     \ /
      Last update: 2023-03-27 00:11    [W:2.212 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site