lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] of: reserved-mem: expose reserved-mem details via debugfs
    Hi Martin,

    Thank you for the patch! Perhaps something to improve:

    [auto build test WARNING on robh/for-next]
    [also build test WARNING on linus/master v6.2-rc7 next-20230206]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Martin-Liu/of-reserved-mem-expose-reserved-mem-details-via-debugfs/20230206-222927
    base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
    patch link: https://lore.kernel.org/r/20230206142714.4151047-1-liumartin%40google.com
    patch subject: [PATCH] of: reserved-mem: expose reserved-mem details via debugfs
    config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230207/202302070307.dJ4f1zXY-lkp@intel.com/config)
    compiler: m68k-linux-gcc (GCC) 12.1.0
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/intel-lab-lkp/linux/commit/5d479d32b3863f2ec8d10d756aa57cf29046e334
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review Martin-Liu/of-reserved-mem-expose-reserved-mem-details-via-debugfs/20230206-222927
    git checkout 5d479d32b3863f2ec8d10d756aa57cf29046e334
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/

    If you fix the issue, kindly add following tag where applicable
    | Reported-by: kernel test robot <lkp@intel.com>

    All warnings (new ones prefixed by >>):

    drivers/of/of_reserved_mem.c: In function 'of_reserved_mem_debug_show':
    >> drivers/of/of_reserved_mem.c:465:46: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'phys_addr_t' {aka 'unsigned int'} [-Wformat=]
    465 | seq_printf(m, "%pa..%pa ( %7lu KB ) %5s %12s %s\n", &rmem->base,
    | ~~~^
    | |
    | long unsigned int
    | %7u
    466 | &end, rmem->size / 1024,
    | ~~~~~~~~~~~~~~~~~
    | |
    | phys_addr_t {aka unsigned int}


    vim +465 drivers/of/of_reserved_mem.c

    450
    451 #if defined(CONFIG_DEBUG_FS)
    452 static int of_reserved_mem_debug_show(struct seq_file *m, void *private)
    453 {
    454 unsigned int i;
    455 size_t sum = 0;
    456
    457 for (i = 0; i < reserved_mem_count; i++) {
    458 const struct reserved_mem *rmem = &reserved_mem[i];
    459 unsigned long node = rmem->fdt_node;
    460 phys_addr_t end = rmem->base + rmem->size - 1;
    461 bool nomap = (of_get_flat_dt_prop(node, "no-map", NULL)) != NULL;
    462 bool reusable = (of_get_flat_dt_prop(node, "reusable", NULL)) != NULL;
    463
    464 sum += rmem->size;
    > 465 seq_printf(m, "%pa..%pa ( %7lu KB ) %5s %12s %s\n", &rmem->base,
    466 &end, rmem->size / 1024,
    467 nomap ? "nomap" : "map",
    468 reusable ? "reusable" : "non-reusable",
    469 rmem->name ? rmem->name : "unknown");
    470 }
    471 seq_printf(m, "Total %d regions, %zu KB\n",
    472 reserved_mem_count,
    473 sum / 1024);
    474 return 0;
    475 }
    476 DEFINE_SHOW_ATTRIBUTE(of_reserved_mem_debug);
    477

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests

    \
     
     \ /
      Last update: 2023-03-27 00:11    [W:4.739 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site