Messages in this thread | | | Date | Mon, 6 Feb 2023 20:21:42 +0100 | Subject | Re: [PATCH v2 7/7] ASoC: dt-bindings: meson: convert axg sound card control to schema | From | Krzysztof Kozlowski <> |
| |
On 06/02/2023 16:34, Jerome Brunet wrote: > Convert the DT binding documentation for the Amlogic axg sound card to > schema. > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- > .../bindings/sound/amlogic,axg-sound-card.txt | 124 ------------ > .../sound/amlogic,axg-sound-card.yaml | 183 ++++++++++++++++++ > 2 files changed, 183 insertions(+), 124 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.txt > create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml >
Thank you for your patch. There is something to discuss/improve.
> -}; > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml > new file mode 100644 > index 000000000000..b7459fad0e7f > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml > @@ -0,0 +1,183 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/amlogic,axg-sound-card.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic AXG sound card > + > +maintainers: > + - Jerome Brunet <jbrunet@baylibre.com> > + > +properties: > + compatible: > + const: amlogic,axg-sound-card > + > + audio-aux-devs: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: list of auxiliary devices > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: |
You still have everywhere | which should be removed. Here and in almost every other description when no special formatting is needed.
Best regards, Krzysztof
| |