lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/1] spi: intel: Remove DANGEROUS tag from pci driver
    Date
    Modern CPUs exposes this controller as PCI device that only uses
    hardware sequencing capabilities which is safer than software
    sequencing.
    Leave the platform driver as *DANGEROUS* and update help text since
    most of these controllers are using software sequencing.

    Signed-off-by: Mauro Lima <mauro.lima@eclypsium.com>
    ---
    drivers/spi/Kconfig | 15 ++++++++-------
    1 file changed, 8 insertions(+), 7 deletions(-)

    diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
    index 87fc2bd16b72..3a362c450cb6 100644
    --- a/drivers/spi/Kconfig
    +++ b/drivers/spi/Kconfig
    @@ -447,7 +447,7 @@ config SPI_INTEL
    tristate

    config SPI_INTEL_PCI
    - tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)"
    + tristate "Intel PCH/PCU SPI flash PCI driver"
    depends on PCI
    depends on X86 || COMPILE_TEST
    depends on SPI_MEM
    @@ -455,8 +455,9 @@ config SPI_INTEL_PCI
    help
    This enables PCI support for the Intel PCH/PCU SPI controller in
    master mode. This controller is present in modern Intel hardware
    - and is used to hold BIOS and other persistent settings. Using
    - this driver it is possible to upgrade BIOS directly from Linux.
    + and is used to hold BIOS and other persistent settings. This
    + driver only supports hardware sequencing mode. Using this
    + driver it is possible to upgrade BIOS directly from Linux.

    Say N here unless you know what you are doing. Overwriting the
    SPI flash may render the system unbootable.
    @@ -471,10 +472,10 @@ config SPI_INTEL_PLATFORM
    select SPI_INTEL
    help
    This enables platform support for the Intel PCH/PCU SPI
    - controller in master mode. This controller is present in modern
    - Intel hardware and is used to hold BIOS and other persistent
    - settings. Using this driver it is possible to upgrade BIOS
    - directly from Linux.
    + controller in master mode that is used to hold BIOS and other
    + persistent settings. Most of these controllers are using
    + software sequencing mode. Using this driver it is possible to
    + upgrade BIOS directly from Linux.

    Say N here unless you know what you are doing. Overwriting the
    SPI flash may render the system unbootable.
    --
    2.39.1
    \
     
     \ /
      Last update: 2023-03-27 00:11    [W:2.376 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site