lkml.org 
[lkml]   [2023]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] staging: vt6655: Macro with braces issue change to inline function
On Sun, Feb 05, 2023 at 02:16:07PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Feb 05, 2023 at 02:08:02PM +0100, Guru Mehar Rachaputi wrote:
> > This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better
> > as '(iobase)' to avoid precedence issues"
> >
> > ---
> > Changes in v3:
> > - Whitespace error from checkpatch fixed
> >
> > Changes in v2:
> > - Macros with one statement that is to call 'iowrite8' function changed
> > to inline function as reviewed by gregkh@linuxfoundation.org.
> > In relation to this, names of the callers of macro are also modified
> > to call this function.
> >
> > Signed-off-by: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
>
> Try to take this patch and apply it to a tree, and see that everything
> below the --- line is thrown away, including your signed-off-by: line :(
>
Sorry, should not a patch contain signed-off-by: line?
I did not understand.

--
Thanks & Regards,
Guru

\
 
 \ /
  Last update: 2023-03-27 00:10    [W:0.826 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site