lkml.org 
[lkml]   [2023]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] checkpatch.pl: Relax commit ID check to allow more than 12 chars
    On Sat, Feb 04, 2023 at 08:57:59AM -0800, Joe Perches wrote:
    > On Sun, 2023-01-29 at 09:52 -0800, Joe Perches wrote:
    > > On Sun, 2023-01-29 at 13:34 +0100, Jonathan Neuschäfer wrote:
    > > > By now, `git log --pretty=%h` (on my copy of linux.git) prints commit
    > > > hashes with 13 digits, because of the number of objects.
    > > >
    > > > Relax the rule in checkpatch.pl to allow a few more digits (up to 16).
    > >
    > > NAK without updating the process docs first.
    >
    > btw: it looks like 12 will still be sufficient for awhile yet
    >
    > $ git count
    > total 1154908
    > $ git -c core.abbrev=5 log --pretty=format:%h | \
    > perl -nE 'chomp;say length' | sort | uniq -c | sort -n -k2
    > 198 5
    > 664613 6
    > 450955 7
    > 36667 8
    > 2312 9
    > 155 10
    > 8 11

    Ok, I get similar stats on my tree (which includes linux-next and a few
    other remotes).

    However, git's default heuristic for %h length uses 13 digits here, so I
    think other people might get 13 digits as well. I could force git to use
    less digits than it naturally would, by setting core.abbrev=12 (and
    document this idea in the documentation), but that doesn't seem nice.
    Therefore, I still think allowing a few more digits is a good idea.


    Thanks,
    Jonathan
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-03-27 00:10    [W:4.737 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site