lkml.org 
[lkml]   [2023]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/3] dt-bindings: thermal: qcom-spmi-adc-tm5: Use generic ADC node name
On Fri, 3 Feb 2023 15:25:01 -0600
Rob Herring <robh@kernel.org> wrote:

> On Wed, Feb 01, 2023 at 09:44:46PM +0100, Marijn Suijten wrote:
> > Update the example to reflect a future requirement for the generic
> > adc-chan node name on ADC channel nodes, while conveying the board name
> > of the channel in a label instead.
>
> I don't think we've defined 'adc-chan' as THE generic name. Looks like
> we have:
>
> adc-chan
> adc-channel
> channel
>
> 'channel' is the most common (except for QCom).
Good spot.

We also have that defined as the channel name in
bindings/iio/adc.yaml

Now this particular binding doesn't use anything from that
generic binding (other than trivial use of reg) but better to be
consistent with it than not!

Thanks,

Jonathan


>
> Rob

\
 
 \ /
  Last update: 2023-03-27 00:10    [W:0.090 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site