lkml.org 
[lkml]   [2023]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 net-next] net: mscc: ocelot: un-export unused regmap symbols
On Sat, Feb 04, 2023 at 03:34:39AM +0200, Vladimir Oltean wrote:
> On Fri, Feb 03, 2023 at 04:12:11PM -0800, Colin Foster wrote:
> > There are no external users of the vsc7514_*_regmap[] symbols. They were
> > exported in commit 32ecd22ba60b ("net: mscc: ocelot: split register
> > definitions to a separate file") with the intention of being used, but the
> > actual structure used in commit 2efaca411c96 ("net: mscc: ocelot: expose
> > vsc7514_regmap definition") ended up being all that was needed.
> >
> > Bury these unnecessary symbols.
> >
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > ---
>
> These can be unexported too:
>
> extern const struct vcap_field vsc7514_vcap_es0_keys[];
> extern const struct vcap_field vsc7514_vcap_es0_actions[];
> extern const struct vcap_field vsc7514_vcap_is1_keys[];
> extern const struct vcap_field vsc7514_vcap_is1_actions[];
> extern const struct vcap_field vsc7514_vcap_is2_keys[];
> extern const struct vcap_field vsc7514_vcap_is2_actions[];

I was as positive as I could have been that I'd grepped (grept?) and saw
those used in Seville, Felix, and ocelot_ext yesterday. I'll fix this
up, and thanks for checking!

>
> I guess we make exceptions for the 24 hour reposting rule when the patch
> has been reviewed?

\
 
 \ /
  Last update: 2023-03-27 00:10    [W:0.389 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site