Messages in this thread | | | Date | Sat, 4 Feb 2023 22:47:06 +0800 | Subject | Re: [PATCH net-next v7 1/1] net:openvswitch:reduce cpu_used_mask memory | From | Eddy Tao <> |
| |
Hi, Simon:
Thank you for the time on the review.
and i looked into net folder and get various results
'net:', 'net: gre:', 'net: bridge:', 'net: thunderx', 'net: sock', 'net: genetlink', and there is also examples as you suggested like 'devlink:'
similarly, in other folders i see similar inconsistency, mm folder is an example.
I turned below links and did not find item regarding to the prefix definition
Link: https://docs.kernel.org/process/maintainer-netdev.html
Link: https://docs.kernel.org/process/submitting-patches.html#submittingpatches
Going through the git log in file net/openvswitch/flow.c, the 'net: openvswitch: ' prefix were used in previous commits.
I think the fix contained 'net' keep the prefix from name collision and better keeps it consistent with its neighbors in the same file
And yes, there should be a blank space after the colon, i miss it, will update the revision, after we nail down the wording of the prefix.
Thanks
eddy
On 2023/2/4 21:28, Simon Horman wrote: > nit: I think the correct prefix for the patch subject is 'openvswitch:' > And there should be a space after the prefix. > > [PATCH net-next v8 1/1] openvswitch: reduce cpu_used_mask
| |