lkml.org 
[lkml]   [2023]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCHv2] fbcon: Check font dimension limits
From
On 1/31/23 15:51, Greg KH wrote:
> On Sun, Jan 29, 2023 at 04:17:40PM +0100, Samuel Thibault wrote:
>> blit_x and blit_y are u32, so fbcon currently cannot support fonts
>> larger than 32x32.
>>
>> The 32x32 case also needs shifting an unsigned int, to properly set bit
>> 31, otherwise we get "UBSAN: shift-out-of-bounds in fbcon_set_font",
>> as reported on:
>>
>> http://lore.kernel.org/all/IA1PR07MB98308653E259A6F2CE94A4AFABCE9@IA1PR07MB9830.namprd07.prod.outlook.com
>> Kernel Branch: 6.2.0-rc5-next-20230124
>> Kernel config: https://drive.google.com/file/d/1F-LszDAizEEH0ZX0HcSR06v5q8FPl2Uv/view?usp=sharing
>> Reproducer: https://drive.google.com/file/d/1mP1jcLBY7vWCNM60OMf-ogw-urQRjNrm/view?usp=sharing
>>
>> Reported-by: Sanan Hasanov <sanan.hasanov@Knights.ucf.edu>
>> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>> Fixes: 2d2699d98492 ("fbcon: font setting should check limitation of driver")
>> Cc: stable@vger.kernel.org
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

applied to fbdev git tree.

Thanks!
Helge

\
 
 \ /
  Last update: 2023-03-27 00:09    [W:0.066 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site