Messages in this thread | | | Date | Fri, 3 Feb 2023 20:07:31 +0100 | From | Simon Horman <> | Subject | Re: [PATCH] rfkill: Use sysfs_emit() to instead of sprintf() |
| |
Hi Bo Liu,
On Wed, Feb 01, 2023 at 03:17:18AM -0500, Bo Liu wrote: > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space.
Thanks for your patch. As it is not a bug fix it should be targeted at 'net-next' (as opposed to 'net'). This should be specified in the patch subject something like this:
[PATCH net-next v2] rfkill: Use sysfs_emit() to instead of sprintf()
> Signed-off-by: Bo Liu <liubo03@inspur.com> > --- > net/rfkill/core.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/net/rfkill/core.c b/net/rfkill/core.c > index b390ff245d5e..a103b2da4ed2 100644 > --- a/net/rfkill/core.c > +++ b/net/rfkill/core.c
...
> @@ -721,7 +721,7 @@ static ssize_t hard_show(struct device *dev, struct device_attribute *attr, > { > struct rfkill *rfkill = to_rfkill(dev); > > - return sprintf(buf, "%d\n", (rfkill->state & RFKILL_BLOCK_HW) ? 1 : 0 ); > + return sysfs_emit(buf, "%d\n", (rfkill->state & RFKILL_BLOCK_HW) ? 1 : 0 ); return sysfs_emit(buf, "%d\n", (rfkill->state & RFKILL_BLOCK_HW) ? 1 : 0);
./scripts/checkpatch.pl complains that there should not be a space before the last ')'.
| |