Messages in this thread | | | From | Etienne Carriere <> | Date | Fri, 3 Feb 2023 19:43:10 +0100 | Subject | Re: [PATCH 2/2] firmware: arm_scmi: optee: use optee system invocation |
| |
Hello Sudeep,
On Fri, 3 Feb 2023 at 18:04, Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Fri, Feb 03, 2023 at 02:36:26PM +0000, Cristian Marussi wrote: > > On Mon, Jan 30, 2023 at 10:41:57AM +0100, Etienne Carriere wrote: > > > Changes SCMI optee transport to enable sys_service capability of > > > its tee context to leverage provisioned system resources in OP-TEE > > > preventing possible deadlock. > > > > > > Such deadlock could happen when many Linux clients invoke OP-TEE are > > > are all suspended waiting for an OP-TEE RPC request access an SCMI > > > resource through the SCMI OP-TEE PTA service. > > > > > > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > > > --- > > > drivers/firmware/arm_scmi/optee.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c > > > index 2a7aeab40e54..91840345e946 100644 > > > --- a/drivers/firmware/arm_scmi/optee.c > > > +++ b/drivers/firmware/arm_scmi/optee.c > > > @@ -559,6 +559,9 @@ static int scmi_optee_service_probe(struct device *dev) > > > if (IS_ERR(tee_ctx)) > > > return -ENODEV; > > > > > > + /* SCMI agent can used TEE system service resources */ > > > + tee_ctx->sys_service = true; > > > + > > > agent = devm_kzalloc(dev, sizeof(*agent), GFP_KERNEL); > > > if (!agent) { > > > ret = -ENOMEM; > > > > LGTM. > > > > I suppose you'll sync-up with Sudeep for how to queue this whole series. > > > > I thought I had responded to this but not. Anyways since TEE changes are > significant than SCMI, you can route it via TEE tree. In that case, > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > > Let me know if that was not your plan.
That's fine. Thanks. I'll ask Jens to apply it next to the optee commit.
Regards, Etienne
> > -- > Regards, > Sudeep
| |