Messages in this thread | | | Date | Fri, 3 Feb 2023 18:54:02 +0100 | Subject | Re: [PATCH v4 1/2] dt-bindings: leds-lp55xx: add ti,charge-pump-mode | From | Krzysztof Kozlowski <> |
| |
On 03/02/2023 16:38, Maarten Zanders wrote: > > On 2/2/23 21:13, Krzysztof Kozlowski wrote: >> + ti,charge-pump-mode: >>> + description: >>> + Set the operating mode of the internal charge pump as defined in >>> + <dt-bindings/leds/leds-lp55xx.h>. Defaults to auto. >>> + $ref: /schemas/types.yaml#/definitions/uint8 >> This should be then uint32 > > Why is that? I specifically chose uint8 because other settings for LED > are also uint8. The implementation is also uint8. I surely hope we'll > never get to >256 modes for a charge pump.
Because all IDs are unsigned int.
Best regards, Krzysztof
| |