Messages in this thread | | | Date | Fri, 03 Feb 2023 06:30:24 +0000 | From | Conor Dooley <> | Subject | RE: [PATCH v3 4/4] RISC-V: Add arch functi ons to support hibernation/suspend-to-disk |
| |
On 3 February 2023 03:43:35 GMT, JeeHeng Sia <jeeheng.sia@starfivetech.com> wrote: > > >> -----Original Message----- >> From: Conor Dooley <conor@kernel.org> >> Sent: Tuesday, 31 January, 2023 7:31 AM >> To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; Alexandre Ghiti <alexghiti@rivosinc.com> >> Cc: paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; linux-riscv@lists.infradead.org; linux- >> kernel@vger.kernel.org; Leyfoon Tan <leyfoon.tan@starfivetech.com>; Mason Huo <mason.huo@starfivetech.com> >> Subject: Re: [PATCH v3 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk >> >> +CC Alex >> >> Alex, could you take a look at the page table bits here when you get a >> chance please? >> >> > + * @a0 - destination >> > + * @a1 - source >> > + */ >> > + .macro copy_page a0, a1 >> > + lui a2, 0x1 >> > + add a2, a2, a0 >> > +.1 : >> > + REG_L t0, 0(a1) >> > + REG_L t1, SZREG(a1) >> > + >> > + REG_S t0, 0(a0) >> > + REG_S t1, SZREG(a0) >> > + >> > + addi a0, a0, 2 * SZREG >> > + addi a1, a1, 2 * SZREG >> > + bne a2, a0, .1 >> >> allmodconfig, clang 15.0.4: >> >> <instantiation>:3:1: error: unexpected token at start of statement >> .1 : >> ^ >> /stuff/linux/arch/riscv/kernel/hibernate-asm.S:83:2: note: while in macro instantiation >> copy_page a0, a1 >> ^ >> <instantiation>:12:15: error: unknown operand >> bne a2, a0, .1 >> ^ >> /stuff/linux/arch/riscv/kernel/hibernate-asm.S:83:2: note: while in macro instantiation >> copy_page a0, a1 >> ^ >> make[5]: *** [/stuff/linux/scripts/Makefile.build:384: arch/riscv/kernel/hibernate-asm.o] Error 1 >Hi Conor, I couldn't reproduce the above error, could you share the build command please?
It was just allmodconfig with LLVM=1
>> >> > + .endm >> > + >> > #endif /* __ASM_ASSEMBLER_H */ > >> Thanks, >> Conor. >
| |