Messages in this thread | | | Date | Tue, 28 Feb 2023 14:49:50 -0800 | Subject | Re: [PATCH v10 08/26] gunyah: rsc_mgr: Add resource manager RPC core | From | Elliot Berman <> |
| |
On 2/27/2023 4:52 PM, Alex Elder wrote: > On 2/23/23 5:13 PM, Elliot Berman wrote: >>> TBH, gunyah.c should be merged as part of resource manager, and check >>> if uuids and features in probe before proceeding further. >>> >> >> >> Ah -- gunyah_rsc_mgr.ko has symbol dependency on gunyah-msgq.ko. >> gunyah-msgq.ko has symbol dependency on gunyah.ko. gunyah.ko doesn't >> have any probe and does all its work on module_init. >> >> In order to merge gunyah.c with resource manager, I would need to >> incorporate message queue mailbox into resource manager. IMO, this >> rapidly moves towards a mega-module which was discouraged previously. > > I missed this discussion; why was it discouraged? > > I can think of some reasons why I guess. But I don't see what > problem comes from linking together a "mega module" that's made > up of well-isolated source files that expose minimal APIs to > one another. All inter-dependent modules will required at once > anyway; I don't understand the benefit of implementing them > separately. Can you explain, or provide some context? Thanks.
I came from some earlier comments from Dmitry:
https://lore.kernel.org/all/250945d2-3940-9830-63e5-beec5f44010b@linaro.org/
Earlier comments from Dmitry were about having bus and drivers in same module. I think same comment applies with mailbox built into the gunyah.ko (message queue is the provider and rsr_mgr is the consumer).
Thanks, Elliot
| |