Messages in this thread | | | Date | Tue, 28 Feb 2023 08:34:17 +0100 | From | Greg KH <> | Subject | Re: [PATCH v2 1/2] Input: atkbd - Make it possible to apply atkbd.reset via kernel quirk |
| |
On Mon, Feb 27, 2023 at 07:59:06PM +0100, Werner Sembach wrote: > atkbd.reset was only a command line parameter. Some devices might have a > known bug that can be worked around by just permanently applying this > quirk. > > This patch adds the ability to do this on the kernel level for known buggy > devices. > > Signed-off-by: Werner Sembach <wse@tuxedocomputers.com> > Cc: stable@vger.kernel.org > --- > drivers/input/keyboard/atkbd.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c > index 246958795f60..ef65c46c4efe 100644 > --- a/drivers/input/keyboard/atkbd.c > +++ b/drivers/input/keyboard/atkbd.c > @@ -1731,6 +1731,12 @@ static int __init atkbd_deactivate_fixup(const struct dmi_system_id *id) > return 1; > } > > +static int __init atkbd_reset_fixup(const struct dmi_system_id *id) > +{ > + atkbd_reset = true; > + return 1;
Why is this returning 1? Who calls this?
And this should be a per-device attribute, not a global one, right?
thanks,
greg k-h
| |