Messages in this thread | | | Date | Tue, 28 Feb 2023 21:44:02 +0100 | From | Michael Walle <> | Subject | Re: [PATCH 2/3] gpio: gpio-regmap: Expose struct gpio_regmap in linux/gpio/regmap.h |
| |
Hi,
Am 2023-02-28 02:53, schrieb William Breathitt Gray: > A struct gpio_regmap is passed as a parameter for reg_mask_xlate(), but > for callbacks to access its members the declaration must be exposed.
That parameter is only an opaque one to call any gpio_regmap_*().
> Move the struct gpio_regmap declaration from drivers/gpio/gpio-regmap.c > to include/linux/gpio/regmap.h so callbacks can properly interact with > struct gpio_regmap members.
That struct should be kept private. It seems you only need the regmap. Either introduce a gpio_regmap_get_regmap() or add the regmap to a private struct and use gpio_regmap_get_drvdata().
-michael
| |