Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v12 06/11] x86/smpboot: Remove initial_stack on 64-bit | Date | Tue, 28 Feb 2023 21:32:55 +0100 |
| |
On Tue, Feb 28 2023 at 16:25, David Woodhouse wrote: > On Tue, 2023-02-28 at 17:13 +0100, Thomas Gleixner wrote: >> Folks, really. > > Also, while those two lines *happen* to be my addition to Brian's > commit message, I don't know if you knew that.
I knew because I read Brians patches _and_ I know your quick changelog style by heart.
> Speak to me how you like; you know I'll still love you. But be nicer > to Brian and Usama.
Hmm. I was not aware that 'Folks, really.' qualifies as not nice nowadays.
>> > +#endif /* CONFIG_SMP */ >> >> Sigh, we should finally make CONFIG_SMP def_bool y ... > > Not today :)
Right, but it's overdue nevertheless to adjust with reality :)
>> > + if (IS_ENABLED(CONFIG_X86_32)) { >> > + initial_stack = idle->thread.sp; >> > + } else { >> > + smpboot_control = cpu; >> > + } >> >> Please remove the pointless brackets. > > I pondered that, but they only get added back again in the next patch. > It just seemed like adding pointless churn.
Fair enough.
Thanks,
tglx
| |