lkml.org 
[lkml]   [2023]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V5 0/3] rpmsg signaling/flowcontrol patches
From


On 21.02.2023 17:03, Sarannya S wrote:
> Added two new RPMSG IOCTLs for rpmsg_char- RPMSG_GET_SIGNAL_IOCTRL and
> RPMSG_SET_SIGNAL_IOCTRL, to set/get the flow.
> Addressed review comments for changing variable names/ desciptions.
>
Hi, your changes mostly don't apply on -next-20230228, please rebase
them. Not sure if I didn't miss anything, but I did it locally to test
this [1]. My Wi-Fi chip on SM6375 seems to send quite some signals calls
and applying this series got rid of "unhandled rx cmd: 15" and the
corresponding timeouts.

Also, please consider using b4 [2] for sending patches, you only sent
them to a couple of people and it didn't even reach patchwork..

Konrad

[1] https://github.com/SoMainline/linux/commits/signals_rebase
[2] https://b4.docs.kernel.org/en/latest/contributor/overview.html
> Sarannya S (3):
> rpmsg: core: Add signal API support
> rpmsg: glink: Add support to handle signals command
> rpmsg: char: Add RPMSG GET/SET SIGNAL IOCTL support
>
> drivers/rpmsg/qcom_glink_native.c | 63 +++++++++++++++++++++++++++++++++++++++
> drivers/rpmsg/rpmsg_char.c | 58 ++++++++++++++++++++++++++++++-----
> drivers/rpmsg/rpmsg_core.c | 20 +++++++++++++
> drivers/rpmsg/rpmsg_internal.h | 2 ++
> include/linux/rpmsg.h | 15 ++++++++++
> include/uapi/linux/rpmsg.h | 12 +++++++-
> 6 files changed, 162 insertions(+), 8 deletions(-)
>

\
 
 \ /
  Last update: 2023-03-27 00:38    [W:1.092 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site