lkml.org 
[lkml]   [2023]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 4/7] x86/resctrl: Add code to setup monitoring at L3 or NODE scope.
Date
>> +	/* When SNC enabled, monitor functions at node instead of L3 cache scope */
>> + if (snc_ways > 1)
>> + r = &rdt_resources_all[RDT_RESOURCE_NODE].r_resctrl;
>> + else
>> + r = &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl;
>
> Could this be hidden in a helper with some name like resctrl_arch_get_mbm_resource()?
> You have the same pattern again in rdt_get_tree(). If this gets more complex in the
> future, it means its outside the filesystem code, and all in one place.

Sounds like a good idea. Thanks.

-Tony
\
 
 \ /
  Last update: 2023-03-27 00:38    [W:0.076 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site