lkml.org 
[lkml]   [2023]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/20] power: supply: remove MODULE_LICENSE in non-modules
    Date
    Since commit 8b41fc4454e ("kbuild: create modules.builtin without
    Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
    are used to identify modules. As a consequence, uses of the macro
    in non-modules will cause modprobe to misidentify their containing
    object file as a module when it is not (false positives), and modprobe
    might succeed rather than failing with a suitable error message.

    So remove it in the files in this commit, none of which can be built as
    modules.

    Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
    Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
    Cc: Luis Chamberlain <mcgrof@kernel.org>
    Cc: linux-modules@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
    Cc: Sebastian Reichel <sre@kernel.org>
    Cc: linux-pm@vger.kernel.org
    ---
    drivers/power/supply/power_supply_core.c | 1 -
    drivers/power/supply/wm97xx_battery.c | 1 -
    2 files changed, 2 deletions(-)

    diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
    index 7c790c41e2fe3..411fb8b8945a7 100644
    --- a/drivers/power/supply/power_supply_core.c
    +++ b/drivers/power/supply/power_supply_core.c
    @@ -1578,4 +1578,3 @@ MODULE_DESCRIPTION("Universal power supply monitor class");
    MODULE_AUTHOR("Ian Molton <spyro@f2s.com>, "
    "Szabolcs Gyurko, "
    "Anton Vorontsov <cbou@mail.ru>");
    -MODULE_LICENSE("GPL");
    diff --git a/drivers/power/supply/wm97xx_battery.c b/drivers/power/supply/wm97xx_battery.c
    index a0e1eaa25d93e..f4b190adb3359 100644
    --- a/drivers/power/supply/wm97xx_battery.c
    +++ b/drivers/power/supply/wm97xx_battery.c
    @@ -271,6 +271,5 @@ static struct platform_driver wm97xx_bat_driver = {

    module_platform_driver(wm97xx_bat_driver);

    -MODULE_LICENSE("GPL");
    MODULE_AUTHOR("Marek Vasut <marek.vasut@gmail.com>");
    MODULE_DESCRIPTION("WM97xx battery driver");
    --
    2.39.1.268.g9de2f9a303
    \
     
     \ /
      Last update: 2023-03-27 00:38    [W:4.358 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site