lkml.org 
[lkml]   [2023]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim
    Hi Yosry,

    Thank you for the patch! Yet something to improve:

    [auto build test ERROR on akpm-mm/mm-everything]
    [cannot apply to vbabka-slab/for-next xfs-linux/for-next v6.2]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214
    base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
    patch link: https://lore.kernel.org/r/20230228085002.2592473-3-yosryahmed%40google.com
    patch subject: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim
    config: x86_64-randconfig-a014-20230227 (https://download.01.org/0day-ci/archive/20230228/202302281959.EmOJaeae-lkp@intel.com/config)
    compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
    reproduce (this is a W=1 build):
    # https://github.com/intel-lab-lkp/linux/commit/f6d2b849f186a927925a29e289d60895048550f5
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214
    git checkout f6d2b849f186a927925a29e289d60895048550f5
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    make W=1 O=build_dir ARCH=x86_64 olddefconfig
    make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

    If you fix the issue, kindly add following tag where applicable
    | Reported-by: kernel test robot <lkp@intel.com>
    | Link: https://lore.kernel.org/oe-kbuild-all/202302281959.EmOJaeae-lkp@intel.com/

    All errors (new ones prefixed by >>):

    >> mm/vmscan.c:549:13: error: redefinition of 'cgroup_reclaim'
    549 | static bool cgroup_reclaim(struct scan_control *sc)
    | ^~~~~~~~~~~~~~
    mm/vmscan.c:191:13: note: previous definition of 'cgroup_reclaim' with type 'bool(struct scan_control *)' {aka '_Bool(struct scan_control *)'}
    191 | static bool cgroup_reclaim(struct scan_control *sc)
    | ^~~~~~~~~~~~~~
    >> mm/vmscan.c:554:13: error: redefinition of 'global_reclaim'
    554 | static bool global_reclaim(struct scan_control *sc)
    | ^~~~~~~~~~~~~~
    mm/vmscan.c:196:13: note: previous definition of 'global_reclaim' with type 'bool(struct scan_control *)' {aka '_Bool(struct scan_control *)'}
    196 | static bool global_reclaim(struct scan_control *sc)
    | ^~~~~~~~~~~~~~
    mm/vmscan.c:196:13: warning: 'global_reclaim' defined but not used [-Wunused-function]


    vim +/cgroup_reclaim +549 mm/vmscan.c

    86750830468506 Yang Shi 2021-05-04 548
    b5ead35e7e1d34 Johannes Weiner 2019-11-30 @549 static bool cgroup_reclaim(struct scan_control *sc)
    89b5fae5368f6a Johannes Weiner 2012-01-12 550 {
    b5ead35e7e1d34 Johannes Weiner 2019-11-30 551 return false;
    89b5fae5368f6a Johannes Weiner 2012-01-12 552 }
    97c9341f727105 Tejun Heo 2015-05-22 553
    a579086c99ed70 Yu Zhao 2022-12-21 @554 static bool global_reclaim(struct scan_control *sc)
    a579086c99ed70 Yu Zhao 2022-12-21 555 {
    a579086c99ed70 Yu Zhao 2022-12-21 556 return true;
    a579086c99ed70 Yu Zhao 2022-12-21 557 }
    a579086c99ed70 Yu Zhao 2022-12-21 558

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests

    \
     
     \ /
      Last update: 2023-03-27 00:38    [W:2.670 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site