lkml.org 
[lkml]   [2023]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 4/6] scsi: ufs: core: Remove redundant check
Date
Hi Bean,

Yes, looks like it's fixed by that patch.

Please drop this one then.

On Sun, 2023-02-26 at 17:23 +0100, Bean Huo wrote:
> On 23.02.23 4:27 PM, Po-Wen Kao wrote:
> > is_mcq_supported() already check on use_mcq_mode.
> >
> > Signed-off-by: Po-Wen Kao <powen.kao@mediatek.com>
> > Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
> > Reviewed-by: Ziqi Chen <quic_ziqichen@quicinc.com>
> > ---
> > drivers/ufs/core/ufshcd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> > index 81c9f07ebfc8..3357cfa23616 100644
> > --- a/drivers/ufs/core/ufshcd.c
> > +++ b/drivers/ufs/core/ufshcd.c
> > @@ -8544,7 +8544,7 @@ static int ufshcd_device_init(struct ufs_hba
> > *hba, bool init_dev_params)
> > hba->scsi_host_added = true;
> > }
> > /* MCQ may be disabled if ufshcd_alloc_mcq() fails */
> > - if (is_mcq_supported(hba) && use_mcq_mode)
>
> This has been removed/optimized by commit:
>
>
https://urldefense.com/v3/__https://patches.linaro.org/project/linux-scsi/patch/8840cea4a57b46dabce18acc39afc50ab826330f.1676567593.git.quic_asutoshd@quicinc.com/__;!!CTRNKA9wMg0ARbw!legN0lOmB4vG3dFE4M0Wm1kLquVrJo9db7WDDHm6YMc2VM2QAhGFKYo9qZmrGnkLM-UNpgMOni5aor9swQ$ 
>
>
> so this patch is not necessary anymore???
>
>
> > + if (is_mcq_supported(hba))
> > ufshcd_config_mcq(hba);
> > }
> >
\
 
 \ /
  Last update: 2023-03-27 00:39    [W:6.440 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site