Messages in this thread | | | From | Yanchao Yang (杨彦超) <> | Subject | Re: [PATCH net-next v3 01/10] net: wwan: tmi: Add PCIe core | Date | Wed, 1 Mar 2023 03:35:05 +0000 |
| |
On Tue, 2023-02-28 at 10:31 -0800, Jakub Kicinski wrote: > On Tue, 28 Feb 2023 07:47:09 +0000 Yanchao Yang (杨彦超) wrote: > > 1. We receive many comments at the beginning of several patches. > > There > > are little comments about other patches. How about other patches > > (patch > > 2~patch 10)? > > It's because patches are too long, so reviewers are unlikely to > allocate sufficiently long block of time to look thru all of > the code in one sitting. > Get it. It’s hard to review the whole patches in one sitting. So V3 has been reduced 4k+ lines compared with V2 according to your suggestion. Do you have any suggestions on that should we wait for feedback on other patches or what we can do to help reviewers to review patches more smoothly? BTW, the patches are reviewed one by one (patch1, patch2, ….), or are controlled by reviewers (there is no obvious order for reviewing the patch)?
> > 2. Need we add your name in the tag “Reviewed-by: “ next version? > > No, no, don't put review tags on patches unless explicitly asked to. Get it.
Many thanks.
| |