Messages in this thread | | | From | Joel Fernandes <> | Date | Tue, 28 Feb 2023 19:45:30 -0500 | Subject | Re: [PATCH] rcu: use try_cmpxchg in check_cpu_stall |
| |
Hey Steve,
On Tue, Feb 28, 2023 at 7:08 PM Steven Rostedt <rostedt@goodmis.org> wrote: [...] > > > > > > > > But in your case, we don't need to update js, in which case the > > > try_cmpxchg() does. > > > > Right, it has lesser value here but I'm curious why you feel it also > > doesn't belong in that ring buffer loop you shared (or did you mean, > > it does belong there but not in other ftrace code modified by Uros?). > > The ring buffer patch had more than one change, where half the updates were > fine, and half were not.
Thanks for all the clarifications. Good to know such loop design patterns can benefit from it!
- Joel
| |